Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename L1 and L2 to parent and child chain in inbox #339

Merged
merged 6 commits into from
Oct 19, 2023
Merged

chore: rename L1 and L2 to parent and child chain in inbox #339

merged 6 commits into from
Oct 19, 2023

Conversation

douglance
Copy link
Contributor

@douglance douglance commented Sep 22, 2023 •
edited
Loading

closes #336

@douglance douglance requested a review from spsjvc September 22, 2023 13:23
@cla-bot cla-bot bot added the cla-signed label Sep 22, 2023
@douglance douglance marked this pull request as draft September 22, 2023 13:32
@douglance douglance force-pushed the dl/#336 branch 2 times, most recently from 4c0cd24 to 042f6a2 Compare September 22, 2023 14:23
@douglance douglance marked this pull request as ready for review September 22, 2023 15:52
@Samuel0147
Copy link

Cool

@douglance douglance changed the base branch from main to v4 October 3, 2023 15:17
@douglance douglance requested a review from yahgwai October 17, 2023 20:45
spsjvc
spsjvc reviewed Oct 19, 2023
View reviewed changes
src/lib/inbox/inbox.ts Show resolved Hide resolved
src/lib/inbox/inbox.ts Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
@spsjvc spsjvc changed the title chore: renames L1/2 to parentChain/chain in inbox chore: rename L1 and L2 to parent chain and child chain in inbox Oct 19, 2023
yahgwai
yahgwai approved these changes Oct 19, 2023
View reviewed changes
src/lib/inbox/inbox.ts Show resolved Hide resolved
spsjvc
spsjvc approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@spsjvc spsjvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spsjvc spsjvc changed the title chore: rename L1 and L2 to parent chain and child chain in inbox chore: rename L1 and L2 to parent and child chain in inbox Oct 19, 2023
@spsjvc spsjvc merged commit 5710ca2 into v4 Oct 19, 2023
6 checks passed
@spsjvc spsjvc deleted the dl/#336 branch October 19, 2023 14:19
douglance added a commit that referenced this pull request Nov 15, 2023
@douglance
chore: rename L1 and L2 to parent and child chain in inbox (#339)
3f8172f
douglance added a commit that referenced this pull request Nov 15, 2023
@douglance
chore: rename L1 and L2 to parent and child chain in inbox (#339)
5c62235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuel0147 Samuel0147 Samuel0147 left review comments

@spsjvc spsjvc spsjvc approved these changes

@yahgwai yahgwai yahgwai approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@douglance @Samuel0147 @yahgwai @spsjvc